lkml.org 
[lkml]   [2017]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status
On Wed, Oct 11, 2017 at 11:31:07AM -0500, Gustavo A. R. Silva wrote:
> Quoting Johan Hovold <johan@kernel.org>:
>
> > On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote:
> >> Hi Johan,
> >>
> >> Quoting Johan Hovold <johan@kernel.org>:
> >
> >> > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
> >> > to figure which people and lists to CC.
> >> >
> >>
> >> I actually did:
> >>
> >> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
> >> drivers/staging/greybus/es2.c
> >>
> >> and this was the output:
> >>
> >> linux-kernel@vger.kernel.org (open list)

> I double checked and this is what happened:
>
> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
> drivers//staging/greybus/es2.c
>
> Notice that double slash after drivers: //

Ah, perhaps something which should be supported.

> >> > We also try to include the module (component) "es2" in the commit
> >> > summary (unless you really are doing things subsystem wide), although
> >> > that has not been enforced for staging clean ups recently.
> >> >
> >>
> >> I got it. I'll take that into account for future patches.
> >
> > Looking at the commit history for the file in questions usually gives a
> > hint about the style used for the corresponding subsystem.
> >
>
> Yep, I usually do that:
>
> $ git log --oneline drivers/staging/greybus/es2.c
>
> This time I got many of these two:
>
> staging: greybus:
> greybus: es2:
>
> so I picked up the first one.
>
> But I get your point and I understand now that I should have used the
> second one.

Good, so you already have the habit of doing so. As I mentioned, this
file in staging is not the best example since the prefix has changed
over time and not really been enforced lately (it should really be
"staging: greybus: es2" now).

Thanks,
Johan

\
 
 \ /
  Last update: 2017-10-12 11:06    [W:0.045 / U:2.468 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site