lkml.org 
[lkml]   [2017]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/9] drm/panel: simple: add a macro for defining display modes in a simpler and less error prone way
Date
Create a macro that eases the definition of display mode parameters by
accecpting the parameters:
freq, hactive, hfront-porch, hsynclen, hback-porch,
vactive, vfront-porch, vsynclen, vback-porch, vrefresh
that can be usually directly taken from an LCD datasheet.

Put the calculations that are now open coded repeating the same
parameters multiple times into the macro expansion.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/gpu/drm/panel/panel-simple.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 474fa75..dec639d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -411,6 +411,20 @@ static const struct panel_desc ampire_am_480272h3tmqw_t01h = {
.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
};

+#define SP_DISPLAY_MODE(freq, ha, hfp, hs, hbp, va, vfp, vs, vbp, vr, flgs) { \
+ .clock = freq, \
+ .hdisplay = ha, \
+ .hsync_start = (ha) + (hfp), \
+ .hsync_end = (ha) + (hfp) + (hs), \
+ .htotal = (ha) + (hfp) + (hs) + (hbp), \
+ .vdisplay = (va), \
+ .vsync_start = (va) + (vfp), \
+ .vsync_end = (va) + (vfp) + (vs), \
+ .vtotal = (va) + (vfp) + (vs) + (vbp), \
+ .vrefresh = vr, \
+ .flags = flgs, \
+ }
+
static const struct drm_display_mode ampire_am800480r3tmqwa1h_mode = {
.clock = 33333,
.hdisplay = 800,
--
2.1.4
\
 
 \ /
  Last update: 2017-10-11 13:46    [W:0.389 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site