Messages in this thread | | | Subject | Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static | From | Christian König <> | Date | Wed, 11 Oct 2017 12:41:23 +0200 |
| |
Am 11.10.2017 um 11:21 schrieb Colin King: > From: Colin Ian King <colin.king@canonical.com> > > The function uvd_v6_0_enc_get_destroy_msg is local to the source and > does not need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be > static? > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> --- > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > index 60af7310a234..71299c67c517 100644 > --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c > @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle > * > * Close up a stream for HW test or if userspace failed to do so > */ > -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, > - bool direct, struct dma_fence **fence) > +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, > + uint32_t handle, > + bool direct, struct dma_fence **fence) > { > const unsigned ib_size_dw = 16; > struct amdgpu_job *job;
| |