lkml.org 
[lkml]   [2017]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/25] thermal/drivers/hisi: Remove pointless lock
    Date
    The threaded interrupt inspect the sensors structure to look in the temp
    threshold field, but this field is read-only in all the code, except in the
    probe function before the threaded interrupt is set. In other words there
    is not race window in the threaded interrupt when reading the field value.

    Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Reviewed-by: Leo Yan <leo.yan@linaro.org>
    ---
    drivers/thermal/hisi_thermal.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
    index 1b44bfe..b657ae4 100644
    --- a/drivers/thermal/hisi_thermal.c
    +++ b/drivers/thermal/hisi_thermal.c
    @@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev)
    static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev)
    {
    struct hisi_thermal_data *data = dev;
    - struct hisi_thermal_sensor *sensor;
    -
    - mutex_lock(&data->thermal_lock);
    - sensor = &data->sensors;
    + struct hisi_thermal_sensor *sensor = &data->sensors;

    dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n",
    sensor->thres_temp);
    - mutex_unlock(&data->thermal_lock);

    thermal_zone_device_update(data->sensors.tzd,
    THERMAL_EVENT_UNSPECIFIED);
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-10-10 20:14    [W:4.789 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site