Messages in this thread | | | Subject | Re: [PATCH] drm/i915: remove redundant check on has_aliasing_ppgtt | From | Colin Ian King <> | Date | Tue, 10 Oct 2017 15:36:16 +0100 |
| |
On 10/10/17 15:35, Joonas Lahtinen wrote: > On Tue, 2017-10-10 at 14:47 +0100, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> There is a previous check to on has_aliasing_ppgtt that returns >> 0 if it is false, so it is impossible for has_aliasing_ppgtt to >> be false on the final return of function intel_sanitize_enable_ppgtt, >> so final return in the function always will return 1. Hence the >> redundant ternary operator can be replaced with a return 1. >> >> Detected by CoverityScan, CID#1357136 ("Logically dead code") >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > > Thanks, I took it a few steps further and removed the variable > altogether. I Cc'd you on the patch.
Yep, it's an improvement on my fix. Thanks for sorting that out.
Colin
> > Regards, Joonas >
| |