lkml.org 
[lkml]   [2017]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines
From
Date
On 2017/9/25 15:24, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2:
> Add changelog.
>
> drivers/acpi/arm64/gtdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> index 597a737..92f9edf 100644
> --- a/drivers/acpi/arm64/gtdt.c
> +++ b/drivers/acpi/arm64/gtdt.c
> @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> struct acpi_gtdt_timer_entry *gtdt_frame;
>
> if (!block->timer_count) {
> - pr_err(FW_BUG "GT block present, but frame count is zero.");
> + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> return -ENODEV;
> }
>

Make sense to me,

Acked-by: Hanjun Guo <hanjun.guo@linaro.org>

Lorenzo, could you pick this up for 4.15?

Thanks
Hanjun

\
 
 \ /
  Last update: 2017-10-10 11:35    [W:0.049 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site