lkml.org 
[lkml]   [2017]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.13 053/160] usb: gadget: udc: atmel: set vbus irqflags explicitly
    Date
    4.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nicolas Ferre <nicolas.ferre@microchip.com>

    commit 6baeda120d90aa637b08f7604de104ab00ce9126 upstream.

    The driver triggers actions on both edges of the vbus signal.

    The former PIO controller was triggering IRQs on both falling and rising edges
    by default. Newer PIO controller don't, so it's better to set it explicitly to
    IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING.

    Without this patch we may trigger the connection with host but only on some
    bouncing signal conditions and thus lose connecting events.

    Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
    Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/udc/atmel_usba_udc.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
    +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
    @@ -29,6 +29,8 @@
    #include <linux/of_gpio.h>

    #include "atmel_usba_udc.h"
    +#define USBA_VBUS_IRQFLAGS (IRQF_ONESHOT \
    + | IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING)

    #ifdef CONFIG_USB_GADGET_DEBUG_FS
    #include <linux/debugfs.h>
    @@ -2361,7 +2363,7 @@ static int usba_udc_probe(struct platfor
    IRQ_NOAUTOEN);
    ret = devm_request_threaded_irq(&pdev->dev,
    gpio_to_irq(udc->vbus_pin), NULL,
    - usba_vbus_irq_thread, IRQF_ONESHOT,
    + usba_vbus_irq_thread, USBA_VBUS_IRQFLAGS,
    "atmel_usba_udc", udc);
    if (ret) {
    udc->vbus_pin = -ENODEV;

    \
     
     \ /
      Last update: 2017-10-10 22:34    [W:4.172 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site