lkml.org 
[lkml]   [2017]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] staging: iio: tsl2x7x: migrate *_thresh_period sysfs attributes to iio_event_spec
On Sun, Oct 01, 2017 at 11:14:46AM +0100, Jonathan Cameron wrote:
> On Fri, 29 Sep 2017 21:09:21 -0400
> Brian Masney <masneyb@onstation.org> wrote:
>
> > The sysfs attributes in_intensity0_thresh_period and
> > in_proximity0_thresh_period are currently directly created by the driver.
> > This patch migrates the creation of these sysfs attributes from the driver
> > to using the IIO core via iio_event_spec.
> >
> > Signed-off-by: Brian Masney <masneyb@onstation.org>
>
> One question down the end about whether we should be using IIO_EV_DIR_EITHER
> rather than IIO_EV_DIR_NONE
>
> NONE is only really for thing where a direction makes not sense rather
> than to remove the direction be specified for a particular element.
>
> Otherwise looks good. I'd just have changed this, but wasn't sure if
> there was deeper logic behind your choice that I was missing!

There wasn't any deeper logic to this. :) I'll test it with
IIO_EV_DIR_EITHER and send v2 with my next batch of cleanups unless you
change it before then.

Thanks,

Brian

\
 
 \ /
  Last update: 2017-10-01 12:58    [W:0.039 / U:1.200 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site