lkml.org 
[lkml]   [2017]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HSI: hsi_char: pr_err() strings should end with newlines
Hi,

On Tue, Sep 26, 2017 at 11:46:14AM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Thanks, queued.

-- Sebastian

> ---
> drivers/hsi/clients/hsi_char.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> index 57f70c2..cf9c2a3 100644
> --- a/drivers/hsi/clients/hsi_char.c
> +++ b/drivers/hsi/clients/hsi_char.c
> @@ -773,13 +773,13 @@ static int __init hsc_init(void)
>
> if ((max_data_size < 4) || (max_data_size > 0x10000) ||
> (max_data_size & (max_data_size - 1))) {
> - pr_err("Invalid max read/write data size");
> + pr_err("Invalid max read/write data size\n");
> return -EINVAL;
> }
>
> ret = hsi_register_client_driver(&hsc_driver);
> if (ret) {
> - pr_err("Error while registering HSI/SSI driver %d", ret);
> + pr_err("Error while registering HSI/SSI driver %d\n", ret);
> return ret;
> }
>
> --
> 1.9.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-10-01 17:14    [W:0.122 / U:1.892 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site