Messages in this thread | | | Date | Mon, 9 Jan 2017 14:27:33 -0800 | From | Shaohua Li <> | Subject | Re: [PATCH V5 00/17] blk-throttle: add .low limit |
| |
On Mon, Jan 09, 2017 at 04:46:35PM -0500, Tejun Heo wrote: > Hello, > > Sorry about the long delay. Generally looks good to me. Overall, > there are only a few things that I think should be addressed.
Thanks for your time!
> * Low limit should default to zero.
I forgot to change it after changing the name from high to low
> * The default values and roles of idle timeout vs. latency target. > > I don't think either would be difficult to address. Oh and a bit more > documentation overall would be nice.
Will fix these.
> Thanks a lot for the great work and happy new year!
Thanks and happy new year!
Best regards, Shaohua
| |