Messages in this thread | | | Subject | Re: [patch] nbd: blk_mq_init_queue returns an error code on failure, not NULL | From | Jens Axboe <> | Date | Mon, 9 Jan 2017 13:41:35 -0700 |
| |
On 01/09/2017 01:27 PM, Omar Sandoval wrote: > On Mon, Jan 09, 2017 at 03:20:31PM -0500, Jeff Moyer wrote: >> Additionally, don't assign directly to disk->queue, otherwise >> blk_put_queue (called via put_disk) will choke (panic) on the errno >> stored there. >> >> Bug found by code inspection after Omar found a similar issue in >> virtio_blk. Compile-tested only. >> >> Signed-off-by: Jeff Moyer <jmoyer@redhat.com> > > Reviewed-by: Omar Sandoval <osandov@fb.com> > > Compile-reviewed only :) Josef can probably test it if he cares enough, > but it looks right.
Looks good to me, too. Josef, you want me to queue this up directly?
-- Jens Axboe
| |