lkml.org 
[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [HMM v15 01/16] mm/free_hot_cold_page: catch ZONE_DEVICE pages
    From
    Date
    On 01/09/2017 01:19 AM, Balbir Singh wrote:
    >> + /*
    >> + * This should never happen ! Page from ZONE_DEVICE always must have an
    >> + * active refcount. Complain about it and try to restore the refcount.
    >> + */
    >> + if (is_zone_device_page(page)) {
    >> + VM_BUG_ON_PAGE(is_zone_device_page(page), page);
    > This can be VM_BUG_ON_PAGE(1, page), hopefully the compiler does the right thing
    > here. I suspect this should be a BUG_ON, independent of CONFIG_DEBUG_VM

    BUG_ON() means "kill the machine dead". Do we really want a guaranteed
    dead machine if someone screws up their refcounting?

    \
     
     \ /
      Last update: 2017-01-09 17:23    [W:3.228 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site