lkml.org 
[lkml]   [2017]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] mm, thp: add new background defrag option
From
Date
On 01/09/2017 11:04 AM, Vlastimil Babka wrote:
> On 01/06/2017 11:20 PM, David Rientjes wrote:
>> I'd leave it to Andrew to decide whether sysfs files should accept
>> multiple modes or not. If you are to propose a patch to do so, I'd
>> encourage you to do the same cleanup of triple_flag_store() that I did and
>> make the gfp mask construction more straight-forward. If you'd like to
>> suggest a different name for "background", I'd be happy to change that if
>> it's more descriptive.
>
> Suggestion is above. I however think your cleanup isn't really needed,
> we can simply keep the existing 3 internal flags, and "madvise+defer"
> would enable two of them, like in my patch. Nothing says that internally
> each option should correspond to exactly one flag.

Forgot to add that if/when you repost this, please CC linux-api and
summarize what else was considered in the changelog. Thanks.

\
 
 \ /
  Last update: 2017-01-09 13:09    [W:0.105 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site