| From | Chris Lapa <> | Subject | [PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to a switch statement. | Date | Mon, 9 Jan 2017 11:47:35 +1100 |
| |
From: Chris Lapa <chris@lapa.com.au>
This is done for readability as the upcoming commits will add a lot of cases.
tested: no
Signed-off-by: Chris Lapa <chris@lapa.com.au> --- drivers/power/supply/bq27xxx_battery.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 3b0dbc6..fd4cc4e 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -635,12 +635,17 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di) */ static bool bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags) { - if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545) + switch (di->chip) { + case BQ27500: + case BQ27541: + case BQ27545: return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD); - if (di->chip == BQ27530 || di->chip == BQ27421) + case BQ27530: + case BQ27421: return flags & BQ27XXX_FLAG_OT; - - return false; + default: + return false; + } } /* -- 2.1.4
|