lkml.org 
[lkml]   [2017]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: speakup: styel fix, octal file permissions
On Sat, Jan 07, 2017 at 05:11:16PM +1300, Derek Robson wrote:
> Changed file permission to octal style,
> Found using checkpatch

Typo in your subject line :(

>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
> drivers/staging/speakup/kobjects.c | 54 +++++++++++++++++++-------------------
> 1 file changed, 27 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index e744aa9730ff..4e7ebc306488 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -865,66 +865,66 @@ static struct kobj_attribute version_attribute =
> __ATTR_RO(version);
>
> static struct kobj_attribute delimiters_attribute =
> - __ATTR(delimiters, S_IWUSR | S_IRUGO, punc_show, punc_store);
> + __ATTR(delimiters, 0644, punc_show, punc_store);
> static struct kobj_attribute ex_num_attribute =
> - __ATTR(ex_num, S_IWUSR | S_IRUGO, punc_show, punc_store);
> + __ATTR(ex_num, 0644, punc_show, punc_store);

Why not just use __ATTR_RW() for all of these instead? Be much easier
and smaller and is recommended instead of spelling out the mode values
everywhere.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-01-07 08:40    [W:0.052 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site