Messages in this thread | | | Subject | Re: [PATCH v2] fscrypt: Factor out bio specific functions | From | Richard Weinberger <> | Date | Sat, 7 Jan 2017 23:40:15 +0100 |
| |
Ted,
Am 07.01.2017 um 20:24 schrieb Theodore Ts'o: > On Wed, Jan 04, 2017 at 12:10:43PM -0800, Eric Biggers wrote: >> >> I thought you're supposed to be able to build the kernel no matter how it's >> configured. If this patch is really too large for 4.10 then perhaps we should >> make FS_ENCRYPTION select CONFIG_BLOCK instead? > > We already have FS_ENCRYPTIOn depending on BLOCK, so this is *not* > fixing a build break.
Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled. UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs. This will enable ENCRYPTION even when no block support is available.
I can make UBIFS depend on BLOCK as intermediate fix. But the real fix is this patch.
Thanks, //richard
| |