Messages in this thread | | | Subject | Re: [PATCH v4 07/15] mtd: nand: move Samsung specific init/detection logic in nand_samsung.c | From | Marek Vasut <> | Date | Sat, 7 Jan 2017 00:53:24 +0100 |
| |
On 01/04/2017 06:08 PM, Boris Brezillon wrote: > On Wed, 4 Jan 2017 16:14:07 +0100 > Marek Vasut <marek.vasut@gmail.com> wrote: > >> On 01/03/2017 02:01 PM, Boris Brezillon wrote: >>> Move Samsung specific initialization and detection logic into >>> nand_samsung.c. This is part of the "separate vendor specific code from >>> core" cleanup process. >>> >>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> >> >> [...] >> >>> diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c >>> index b3a332f37e14..05e9366696c9 100644 >>> --- a/drivers/mtd/nand/nand_ids.c >>> +++ b/drivers/mtd/nand/nand_ids.c >>> @@ -10,7 +10,7 @@ >>> #include <linux/mtd/nand.h> >>> #include <linux/sizes.h> >>> >>> -#define LP_OPTIONS NAND_SAMSUNG_LP_OPTIONS >>> +#define LP_OPTIONS 0 >>> #define LP_OPTIONS16 (LP_OPTIONS | NAND_BUSWIDTH_16) >>> >>> #define SP_OPTIONS NAND_NEED_READRDY >>> @@ -169,10 +169,12 @@ struct nand_flash_dev nand_flash_ids[] = { >>> }; >>> >>> /* Manufacturer IDs */ >>> +extern const struct nand_manufacturer_ops samsung_nand_manuf_ops; >> >> Is the extern needed ? > > Yes, unless you have another solution. If you remove the extern keyword > you just redeclare samsung_nand_manuf_ops here, which is not what we > want.
Maybe some accessor function can help ?
-- Best regards, Marek Vasut
| |