Messages in this thread | | | Subject | Re: [PATCH v2 2/5] arm64: Work around Falkor erratum 1003 | From | Timur Tabi <> | Date | Fri, 6 Jan 2017 09:49:13 -0600 |
| |
Christopher Covington wrote: >> > Also, since this can't be changed via the menu, why bother putting it in? > I put it in in response to review comments asking for the magic number to > be clarified by a #define or variable. I could not find a suitably shared > header between the files in question, so I used the Kconfig machinery to > generate the #define.
I don't think that's the right approach. Kconfigs are not an alternative to header files. Is the ASID configurable? If you just put some text after the "int" then it because a menu option that the user can select and change.
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation.
| |