Messages in this thread | | | Subject | Re: [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies | From | Auger Eric <> | Date | Fri, 6 Jan 2017 12:46:41 +0100 |
| |
On 06/01/2017 11:59, Joerg Roedel wrote: > On Thu, Jan 05, 2017 at 07:04:29PM +0000, Eric Auger wrote: >> struct iommu_dma_cookie { >> - struct iova_domain iovad; >> - struct list_head msi_page_list; >> - spinlock_t msi_lock; >> + union { >> + struct iova_domain iovad; >> + dma_addr_t msi_iova; >> + }; >> + struct list_head msi_page_list; >> + spinlock_t msi_lock; >> + enum iommu_dma_cookie_type type; > > Please move the type to the beginning of the struct and add a comment > how the type relates to the union.
Sure
Thank you for the review.
Best regards
Eric > > > > Joerg >
| |