Messages in this thread | | | From | Appana Durga Kedareswara Rao <> | Subject | RE: [PATCH v2 2/3] dmaeninge: xilinx_dma: Fix bug in multiple frame stores scenario in vdma | Date | Wed, 4 Jan 2017 06:57:05 +0000 |
| |
Hi Jose Miguel Abreu,
Thanks for the review...
> >> If so then there is no race condition, but the HW image that I have > >> does not have this register enabled so I was getting this result > >> (memory corruption because not all framebuffers had addresses set). > > Thanks for the explanation. > > Agree the issue that you mentioned won't come when > > XILINX_DMA_REG_FRMSTORE > > (C_ENABLE_DEBUG_INFO_5 and C_ENABLE_DEBUG_INFO_13) Register is > enabled in the IP. > > But this register won't get enabled with the default IP configuration > (C_ENABLE_DEBUG_INFO_5 and C_ENABLE_DEBUG_INFO_13). > > > > When user is not enabled XILINX_DMA_REG_FRMSTORE in the h/w and > submits frames less than h/w capable. > > The solution that I am thinking is to throw an error in the driver > > saying that either enable the num frame store feature in the IP or submit the > frames up to h/w capable what do you think??? > > Sounds fine by me.
Thanks posted the v3 series please review when you have some time...
Regards, Kedar.
> > Best regards, > Jose Miguel Abreu > > > > > Regards, > > Kedar. > > > >> Best regards, > >> Jose Miguel Abreu > >> > >>> Regards, > >>> Kedar. > >>> > >>>> Best regards, > >>>> Jose Miguel Abreu > >>>>
| |