lkml.org 
[lkml]   [2017]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions
On Wed, Jan 4, 2017 at 3:20 AM, Derek Robson <robsonde@gmail.com> wrote:
> Fixed coding style issue, found with Checkpatch.pl
> changed permissions to octal style.

You missed SoB.

> @@ -37,7 +37,7 @@
> "3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
>
> static bool emulate;
> -module_param(emulate, bool, 0);
> +module_param(emulate, bool, 0000);

Why not to allow reading as well?

> MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-01-04 10:43    [W:0.056 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site