Messages in this thread | | | Date | Wed, 4 Jan 2017 22:55:47 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines |
| |
> From e362a0277fd1bd6112f258664d8831d9bc6b78da Mon Sep 17 00:00:00 2001 > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Date: Wed, 4 Jan 2017 09:33:43 -0800 > Subject: [PATCH] i2c: do not enable fall back to Host Notify by default > > Falling back unconditionally to HostNotify as primary client's interrupt > breaks some drivers which alter their functionality depending on whether > interrupt is present or not, so let's introduce a board flag telling I2C > core explicitly if we want wired interrupt or HostNotify-based one: > I2C_CLIENT_HOST_NOTIFY. > > For DT-based systems we introduce "host-notofy" property that we convert > to I2C_CLIENT_HOST_NOTIFY board flag. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Yay, this looks better to me. One nit:
> +Alternatively, devices supporting SMbus Host Notify, and connected to > +adapters that support this feature, may use "host-notify" property. I2C > +core will create a virtual interrupt for Host Notify and assign it as > +primary interrupt for the slave.
This paragraph sounds Linux-ish while binding docs should be OS agnostic. Maybe we can shorten the second sentence to "It will be assigned then as the primary interrupt for the slave."?
[unhandled content-type:application/pgp-signature]
| |