Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver | Date | Tue, 31 Jan 2017 16:29:58 +0100 | From | Paul Cercueil <> |
| |
Le 2017-01-31 15:20, Linus Walleij a écrit :
>> + of_property_read_u32(dev->of_node, "base", &jzgc->gc.base); > > Remove this. Dynamic allocation should be fine, if you're using the > new userspace ABI like tools/gpio/* or libgpiod and only that and > in-kernel > consumers, dynamic numbers are just fine.
The problem is that the QI_LB60 board code still have a lot of references to global GPIO numbers. Just grep for JZ_GPIO_PORT in arch/mips/jz4740/board-qi_lb60.c to see what I mean...
-Paul
| ![\](/images/icornerr.gif) |