lkml.org 
[lkml]   [2017]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring
From
Date
On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> The u64 x variable in sysfs_display_ring is unused.
> This patch remove it.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>


well spot

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>


> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index b494bc2..f0ce780 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2890,9 +2890,7 @@ static void sysfs_display_ring(void *head, int size, int extend_desc,
> struct dma_desc *p = (struct dma_desc *)head;
>
> for (i = 0; i < size; i++) {
> - u64 x;
> if (extend_desc) {
> - x = *(u64 *) ep;
> seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> i, (unsigned int)virt_to_phys(ep),
> le32_to_cpu(ep->basic.des0),
> @@ -2901,7 +2899,6 @@ static void sysfs_display_ring(void *head, int size, int extend_desc,
> le32_to_cpu(ep->basic.des3));
> ep++;
> } else {
> - x = *(u64 *) p;
> seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> i, (unsigned int)virt_to_phys(ep),
> le32_to_cpu(p->des0), le32_to_cpu(p->des1),
>

\
 
 \ /
  Last update: 2017-01-31 11:12    [W:0.465 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site