lkml.org 
[lkml]   [2017]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 02/17] net: stmmac: Remove the bus_setup function pointer
    From
    Date
    On 1/31/2017 10:11 AM, Corentin Labbe wrote:
    > The bus_setup function pointer is not used at all, this patch remove it.

    indeed this was used and documented on some previous kernels where some
    ST40/SH4 platforms (w/o DT).

    It's ok to remove it in the new MAC generation; I do not think that
    ST will re-use it on new development.

    Peppe

    >
    > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
    > ---
    > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ----
    > include/linux/stmmac.h | 1 -
    > 2 files changed, 5 deletions(-)
    >
    > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    > index e3f6389..bf2d8e6 100644
    > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    > @@ -1671,10 +1671,6 @@ static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)
    > /* Copy the MAC addr into the HW */
    > priv->hw->mac->set_umac_addr(priv->hw, dev->dev_addr, 0);
    >
    > - /* If required, perform hw setup of the bus. */
    > - if (priv->plat->bus_setup)
    > - priv->plat->bus_setup(priv->ioaddr);
    > -
    > /* PS and related bits will be programmed according to the speed */
    > if (priv->hw->pcs) {
    > int speed = priv->plat->mac_port_sel_speed;
    > diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
    > index 266dab9..2d82df9 100644
    > --- a/include/linux/stmmac.h
    > +++ b/include/linux/stmmac.h
    > @@ -135,7 +135,6 @@ struct plat_stmmacenet_data {
    > int tx_fifo_size;
    > int rx_fifo_size;
    > void (*fix_mac_speed)(void *priv, unsigned int speed);
    > - void (*bus_setup)(void __iomem *ioaddr);
    > int (*init)(struct platform_device *pdev, void *priv);
    > void (*exit)(struct platform_device *pdev, void *priv);
    > void *bsp_priv;
    >

    \
     
     \ /
      Last update: 2017-01-31 11:02    [W:4.961 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site