lkml.org 
[lkml]   [2017]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf tools: Create for_each_event{_system, _file} macros for tracepoints iteration
From
Date


On 01/30/2017 09:38 PM, Jiri Olsa wrote:
> On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:
>
> SNIP
>
>>> looks almost the same as for_each_event_system macro,
>>> what's the difference other than 'ftrace' check?
>>
>> Little thing.
>> In parse-events.c for_each_event macro contains
>> tp_event_has_id() function But this function isn't used in
>> util/trace-event-info.c
>>
>>> also why's one 'file' and the other 'system'? looks
>>
>> Just, I follow the name of each function that use the macros..
>>
>>> like we coud have just one macro in here
>>>
>>
>> I understood. :)
>> How about this ?
>
>
> looks ok, but can't apply it.. it's probably mangled
>

I got it.
I'll resend this changed patch!

Thanks,
Taeung

\
 
 \ /
  Last update: 2017-01-31 03:47    [W:0.045 / U:1.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site