Messages in this thread | | | Subject | Re: [PATCH 2/4] watchdog: iTCO_wdt: Use device managed resources | From | Guenter Roeck <> | Date | Tue, 3 Jan 2017 18:44:52 -0800 |
| |
On 01/03/2017 02:41 PM, Andy Shevchenko wrote: > On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck <linux@roeck-us.net> wrote: >> Using device managed resources simplifies error handling and cleanup, >> and to reduce the likelyhood of errors. >> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Does it make sense to convert to dev_err() at some point? >
I tried. It gives me
[59886.759774] iTCO_vendor_support: vendor-support=0 [59886.760452] iTCO_wdt: Intel TCO WatchDog Timer Driver v1.11 [59886.760540] iTCO_wdt iTCO_wdt.0.auto: Found a 9 Series TCO device (Version=2, TCOBASE=0x1860) [59886.761849] iTCO_wdt iTCO_wdt.0.auto: initialized. heartbeat=30 sec (nowayout=0)
which I don't really like too much. Let's stick with pr_{info,err}.
Thanks, Guenter
| |