lkml.org 
[lkml]   [2017]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
    On Tue, Jan 03, 2017 at 04:53:13AM -0800, Max Bires wrote:
    > Without a bool string present, using "# CONFIG_DEVPORT is not set" in
    > defconfig files would not actually unset devport. This ensured that
    > /dev/port was always on, but there are reasons a user may wish to disable
    > it (smaller kernel, attack surface reduction) if it's not being used. Adding
    > a message here in order to make this user visible.
    >
    > Signed-off-by: Max Bires <jbires@google.com>
    > Acked-by: Arnd Bergmann <arnd@arndb.de>
    > ---
    > drivers/char/Kconfig | 5 ++++-
    > 1 file changed, 4 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
    > index 7ad3127..e8fc493 100644
    > --- a/drivers/char/Kconfig
    > +++ b/drivers/char/Kconfig
    > @@ -589,10 +589,13 @@ config TELCLOCK
    > controlling the behavior of this hardware.
    >
    > config DEVPORT
    > - bool
    > + bool "/dev/port character device"
    > depends on !M68K
    > depends on ISA || PCI
    > default y
    > + help
    > + Say Y here if you want to support the /dev/port device. The
    > + /dev/port device is similar to /dev/mem, but for I/O ports.
    >
    > config DCC_TTY
    > tristate "DCC tty driver"

    This does not apply at all to 4.10-rc2, what did you make it against?
    Please redo it so that I can actually apply it...

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2017-01-03 14:54    [W:4.938 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site