Messages in this thread | | | From | "Gideon D'souza" <> | Date | Fri, 27 Jan 2017 22:48:31 +0530 | Subject | Re: [PATCH 2/2] m68k: replaced gcc specific macros with ones from compiler.h |
| |
>You've gone from printf to print here. This commit is breaking the >linux-next builds on m68k. I see the kbuild bot tripped over the same >issue and did the same bisect.
I did do a build before sending, as you may guess I'm not on an m68k machine.
Forgive the newbie please!
I'm re-sending my patch with the correction.
On Fri, Jan 27, 2017 at 10:09 PM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > On Tue, Jan 24, 2017 at 7:14 AM, Gideon Israel Dsouza > <gidisrael@gmail.com> wrote: >> There is <linux/compiler.h> which provides macros for various gcc specific >> constructs. Eg: __weak for __attribute__((weak)). I've cleaned all >> instances of gcc specific attributes with the right macros for all files >> under /arch/m68k >> >> This patch depends on the previous with changes in > >> @@ -17,6 +18,6 @@ void nf_init(void); >> void nf_shutdown(void); >> >> void nfprint(const char *fmt, ...) >> - __attribute__ ((format (printf, 1, 2))); >> + __print(1, 2); >> > > You've gone from printf to print here. This commit is breaking the > linux-next builds on m68k. I see the kbuild bot tripped over the same > issue and did the same bisect. > > http://kisskb.ellerman.id.au/kisskb/buildresult/12916834/ > > Paul. > --
| |