Messages in this thread | | | Date | Fri, 27 Jan 2017 09:24:16 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted |
| |
On Fri, Jan 27, 2017 at 08:43:27AM +0200, Jarkko Sakkinen wrote: > On Thu, Jan 26, 2017 at 11:32:52AM -0700, Jason Gunthorpe wrote: > > On Thu, Jan 26, 2017 at 01:27:14PM +0200, Jarkko Sakkinen wrote: > > > > > "The error code handling is bogus as any error code that has the bits > > > set that TPM_RC_HASH could pass. Implemented tpm2_rc_value() helper to > > > parse the error value from FMT0 and FMT1 error codes to use to check the > > > error so that these types of mistakes is prevented in the future." > > > > Great thanks > > > > Jason > > Can I put your Reviewed-by? I would like to get this into 4.11.
I'm not up to speed on the TPM2 parsing, but it looks OK based on your description.
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Jason
| |