lkml.org 
[lkml]   [2017]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC v2 08/10] KVM: arm/arm64: Set up a background timer for the physical timer emulation
    Date
    Set a background timer for the EL1 physical timer emulation while VMs
    are running, so that VMs get the physical timer interrupts in a timely
    manner.

    Schedule the background timer on entry to the VM and cancel it on exit.
    This would not have any performance impact to the guest OSes that
    currently use the virtual timer since the physical timer is always not
    enabled.

    Signed-off-by: Jintack Lim <jintack@cs.columbia.edu>
    ---
    virt/kvm/arm/arch_timer.c | 26 +++++++++++++++++++++++++-
    1 file changed, 25 insertions(+), 1 deletion(-)

    diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c
    index d3925e2..b366bb2 100644
    --- a/virt/kvm/arm/arch_timer.c
    +++ b/virt/kvm/arm/arch_timer.c
    @@ -247,6 +247,23 @@ static int kvm_timer_update_state(struct kvm_vcpu *vcpu)
    return 0;
    }

    +/* Schedule the background timer for the emulated timer. */
    +static void kvm_timer_emulate(struct kvm_vcpu *vcpu,
    + struct arch_timer_context *timer_ctx)
    +{
    + struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu;
    +
    + if (kvm_timer_should_fire(vcpu, timer_ctx))
    + return;
    +
    + if (!kvm_timer_irq_can_fire(timer_ctx))
    + return;
    +
    + /* The timer has not yet expired, schedule a background timer */
    + BUG_ON(timer_is_armed(timer));
    + timer_arm(timer, kvm_timer_compute_delta(vcpu, timer_ctx));
    +}
    +
    /*
    * Schedule the background timer before calling kvm_vcpu_block, so that this
    * thread is removed from its waitqueue and made runnable when there's a timer
    @@ -306,6 +323,9 @@ void kvm_timer_flush_hwstate(struct kvm_vcpu *vcpu)
    if (kvm_timer_update_state(vcpu))
    return;

    + /* Set the background timer for the physical timer emulation. */
    + kvm_timer_emulate(vcpu, vcpu_ptimer(vcpu));
    +
    /*
    * If we enter the guest with the virtual input level to the VGIC
    * asserted, then we have already told the VGIC what we need to, and
    @@ -368,7 +388,11 @@ void kvm_timer_sync_hwstate(struct kvm_vcpu *vcpu)
    {
    struct arch_timer_cpu *timer = &vcpu->arch.timer_cpu;

    - BUG_ON(timer_is_armed(timer));
    + /*
    + * This is to cancel the background timer for the physical timer
    + * emulation if it is set.
    + */
    + timer_disarm(timer);

    /*
    * The guest could have modified the timer registers or the timer
    --
    1.9.1

    \
     
     \ /
      Last update: 2017-01-27 02:08    [W:4.272 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site