Messages in this thread | | | From | Logan Gunthorpe <> | Date | Thu, 26 Jan 2017 13:00:52 -0700 | Subject | Re: [PATCH v2 0/4] Style fixes: open code obfuscating macros |
| |
Hi,
It's been a couple weeks... Any thoughts on this?
Thanks,
Logan
On 10/01/17 05:33 PM, Logan Gunthorpe wrote: > Hi, > > Here's an updated version of the style fixes patchset. The differences > from v1 are: > > 1) Rebased onto Jon Mason's current NTB branch > > 2) Added two more patches to convert the print lines to use the ntb > device and not the pci one. This seems more sane, shortens a bunch > of lines and removes the need for temporaries. > > Note with (2): I've tried my best to ensure that statements that print > before the ntb device is registered still use the PCI device. However, > someone should probably review and test this as I don't have access > to all types of hardware to do that. > > Thanks, > > Logan > > > > Logan Gunthorpe (4): > ntb_hw_amd: Style fixes: open code macros that just obfuscate code > ntb_hw_intel: Style fixes: open code macros that just obfuscate code > ntb_hw_amd: Print kernel messages with the ntb device not the pci one > ntb_hw_intel: Print kernel messages with the ntb device not the pci > one > > drivers/ntb/hw/amd/ntb_hw_amd.c | 60 +++++------ > drivers/ntb/hw/amd/ntb_hw_amd.h | 3 - > drivers/ntb/hw/intel/ntb_hw_intel.c | 192 +++++++++++++++++------------------- > drivers/ntb/hw/intel/ntb_hw_intel.h | 3 - > 4 files changed, 124 insertions(+), 134 deletions(-) > > -- > 2.1.4 >
| |