Messages in this thread | | | From | Andy Lutomirski <> | Date | Thu, 26 Jan 2017 09:25:04 -0800 | Subject | Re: [PATCH v1 1/3] x86/pvclock: add setter for pvclock_pvti_cpu0_va |
| |
On Wed, Jan 25, 2017 at 9:33 AM, Joao Martins <joao.m.martins@oracle.com> wrote: > Right now there is only a pvclock_pvti_cpu0_va() which is defined > on kvmclock since: > > commit dac16fba6fc5 > ("x86/vdso: Get pvclock data from the vvar VMA instead of the fixmap") > > The only user of this interface was kvm. This commit moves > pvclock_pvti_cpu0_va to pvclock which is a more generic place to have it > and adds the correspondent setter routine for it. This allows other > pvclock-based clocksources to use it, such as Xen.
With a minor nit:
Acked-by: Andy Lutomirski <luto@kernel.org>
> +#else > +static inline void pvclock_set_pvti_cpu0_va(struct pvclock_vsyscall_time_info *pvti) > +{ > +}
How about just not providing pvclock_set_pvti_cpu0_va() in this case? It'll save three lines of code, and, more importantly, it will force us to notice if we screw up the Kconfig stuff.
| |