lkml.org 
[lkml]   [2017]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 05/14] ARM: davinci: da850: add con_id for the SATA clock
From
Date


On 01/23/2017 11:00 AM, Bartosz Golaszewski wrote:
> The ahci-da850 SATA driver is now capable of retrieving clocks by
> con_id. Add the connection id for the sysclk2-derived SATA clock.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> arch/arm/mach-davinci/da850.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index 1d873d1..dbf1daa 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -571,7 +571,7 @@ static struct clk_lookup da850_clks[] = {
> CLK("spi_davinci.0", NULL, &spi0_clk),
> CLK("spi_davinci.1", NULL, &spi1_clk),
> CLK("vpif", NULL, &vpif_clk),
> - CLK("ahci_da850", NULL, &sata_clk),
> + CLK("ahci_da850", "sata", &sata_clk),

I'm worry a bit - wouldn't this cause future problems with PM runtime
(if it will be the case)?

If this is functional clock - shouldn't it be "fck" to
follow PM domain con_id list for davinci? (arch/arm/mach-davinci/pm_domain.c)

> CLK("davinci-rproc.0", NULL, &dsp_clk),
> CLK(NULL, NULL, &ehrpwm_clk),
> CLK("ehrpwm.0", "fck", &ehrpwm0_clk),
>

--
regards,
-grygorii

\
 
 \ /
  Last update: 2017-01-26 18:01    [W:0.655 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site