Messages in this thread Patch in this message | | | Date | Thu, 26 Jan 2017 07:28:39 -0800 | From | tip-bot for Markus Elfring <> | Subject | [tip:perf/core] perf probe: Delete an unnecessary check in try_to_find_absolute_address() |
| |
Commit-ID: 42e233cacc052bd545417c68155f2b9abd1bab72 Gitweb: http://git.kernel.org/tip/42e233cacc052bd545417c68155f2b9abd1bab72 Author: Markus Elfring <elfring@users.sourceforge.net> AuthorDate: Mon, 23 Jan 2017 14:54:26 +0100 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 26 Jan 2017 11:42:55 -0300
perf probe: Delete an unnecessary check in try_to_find_absolute_address()
Remove a condition check which is unnecessary at the end because this source code place should usually only be reached with a non-zero pointer.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: He Kuang <hekuang@huawei.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Milian Wolff <milian.wolff@kdab.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> Cc: Wang Nan <wangnan0@huawei.com> Cc: kernel-janitors@vger.kernel.org Link: http://lkml.kernel.org/r/a3f2473b-6383-a326-bce0-b826423608b8@users.sourceforge.net Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/probe-event.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index 4a57c8a..cdfc468 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -3004,10 +3004,8 @@ static int try_to_find_absolute_address(struct perf_probe_event *pev, return 1; errout: - if (*tevs) { - clear_probe_trace_events(*tevs, 1); - *tevs = NULL; - } + clear_probe_trace_events(*tevs, 1); + *tevs = NULL; return err; }
| |