Messages in this thread | | | Subject | Re: [PATCH 04/13] Input: keyboard - Use local variables consistently | From | Guenter Roeck <> | Date | Thu, 26 Jan 2017 06:28:37 -0800 |
| |
On 01/26/2017 02:31 AM, Linus Walleij wrote: > On Sat, Jan 21, 2017 at 7:45 PM, Guenter Roeck <linux@roeck-us.net> wrote: > >> If a function declares a variable to access a structure element, >> use it conssistently. > > Weird spelling :) > Call id sssnaky :-)
Guenter
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net> > >> - error = devm_gpio_request_one(&pdev->dev, button->gpio, flags, >> - desc); >> + error = devm_gpio_request_one(dev, button->gpio, flags, desc); > > I think I have changes in the GPIO tree touching these code sites. > > I put those on an immutable branch so Dmitry can pull it if he needs > it as a base for this patch: > https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/commit/?h=ib-gpiod-flags > > Yours, > Linus Walleij >
| |