Messages in this thread | | | Date | Thu, 26 Jan 2017 12:14:07 +0100 (CET) | From | Andreas Schultz <> | Subject | Re: [PATCH 0/5] GTP: Fine-tuning for some function implementations |
| |
Hi Markus,
----- On Jan 26, 2017, at 11:15 AM, SF Markus Elfring elfring@users.sourceforge.net wrote:
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 26 Jan 2017 11:10:01 +0100 > > A few update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Use kmalloc_array() in gtp_hashtable_new() > Improve another size determination in ipv4_pdp_add() > Adjust 12 checks for null pointers > Rename jump labels in gtp_encap_enable() > Rename jump labels in gtp_hashtable_new()
Looks good to me, for all the above:
Reviewed-by: Andreas Schultz <aschultz@tpip.net>
Andreas
> > drivers/net/gtp.c | 46 ++++++++++++++++++++++++---------------------- > 1 file changed, 24 insertions(+), 22 deletions(-) > > -- > 2.11.0
| |