lkml.org 
[lkml]   [2017]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 3/3] watchdog: zx2967: add watchdog controller driver for ZTE's zx2967 family
From
Date
On 01/24/2017 06:16 PM, Baoyou Xie wrote:
>
[ ... ]
> +
> + ret = of_parse_phandle_with_fixed_args(dev->of_node,
> + "zte,wdt-reset-sysctrl", 3, 0, &out_args);
> + if (ret)
> + return;
> +
> + offset = out_args.args[0];
> + config = out_args.args[1];
> + mask = out_args.args[2];
> +
> + regmap = syscon_node_to_regmap(out_args.np <http://out_args.np>);
> + if (IS_ERR(regmap))
> + return;
> +
> + regmap_update_bits(regmap, offset, mask, config);
>
>
> Another comment suggested adding
> of_node_put(out_args.np <http://out_args.np>);
> here.
>
>
> is it really? most of the driver that call this function don't call of_node_put. but it seems harmless to call of_node_put.
>
>
Even if everyone else is doing things wrong, that doesn't mean
that you should do the same, nor is it a good idea to use it
as argument.

Guenter

\
 
 \ /
  Last update: 2017-01-25 03:44    [W:0.048 / U:1.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site