Messages in this thread | | | From | Alexei Starovoitov <> | Date | Tue, 24 Jan 2017 09:53:34 -0800 | Subject | Re: [PATCH] bpf: don't kfree an uninitialized im_node |
| |
On Tue, Jan 24, 2017 at 6:16 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > There are some error exit paths to the label 'out' that end up > kfree'ing an uninitialized im_node. Fix this by inititializing > im_node to NULL to avoid kfree'ing a garbage address.
this fix already landed. See: commit d140199af510 ("bpf, lpm: fix kfree of im_node in trie_update_elem")
> Issue found by CoverityScan, CID#1398022 ("Uninitialized pointer read")
Nice. Good to know that static analysis can do such checks.
| |