Messages in this thread | | | Subject | Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn | From | Joe Perches <> | Date | Sun, 22 Jan 2017 22:43:57 -0800 |
| |
On Sat, 2017-01-21 at 11:20 -0800, Florian Fainelli wrote: > We have a device reference, utilize it instead of pr_warn().
There is at least one more hwmon to convert in applesmc.c
Perhaps a coccinelle script?
Two questions for Julia Lawall:
o is there a better way to do this than repeat the blocks one for each replacement o can struct device * dev be made an arbitrary identifier
$ cat dev_printk.cocci @@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_emerg( + dev_emerg(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_crit( + dev_crit(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_alert( + dev_alert(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_err( + dev_err(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_notice( + dev_notice(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_warn( + dev_warn(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_info( + dev_info(dev, ...); ...> }
@@ identifier fn; type T; @@
T fn ( ..., struct device * dev, ... ) { <... - pr_debug( + dev_dbg(dev, ...); ...> }
| |