Messages in this thread | | | Date | Mon, 23 Jan 2017 10:01:37 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/4] perf hists browser: Add e/c key handlers to expand callchain for current entry |
| |
On Fri, Jan 20, 2017 at 01:43:26PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 20, 2017 at 01:41:33PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Jan 20, 2017 at 10:20:30AM +0100, Jiri Olsa escreveu: > > > Currently we allow only to expand or collapse all entries > > > in the browser with E or C keys. Allow user to expand or > > > collapse only current entry in the browser with e or c key. > > > > I guess we can start with this but then fix it to collapse just the > > subtree, not the whole tree for the current hist_entry, for big > > callchains we can have multiple sub(sub)trees, being able to > > expand/collapse just from where we are in a callchain seems even better. > > > > Applying anyway, better than what we have now, > > Also I think that pressing 'e' on an already expanded tree should mean > 'c', i.e. make it a toggle, so that we can go back and forth faster.
yep, that was my impression also, but wanted to keep the current way
I think we could use only C/c keys to toggle 'collapse all'/'collapse current'
thanks, jirka
| |