lkml.org 
[lkml]   [2017]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()
From
Date
On 01/21/2017 11:38 PM, Dmitry Torokhov wrote:
> Nobody calls input_get_drvdata() so setting it is not required.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

Surprisingly, there is about a dozen of those. I'll send a series of
coccinelle generated patches later.

Guenter

> ---
> drivers/input/touchscreen/max11801_ts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> index d87b89da114e..a595ae5284e3 100644
> --- a/drivers/input/touchscreen/max11801_ts.c
> +++ b/drivers/input/touchscreen/max11801_ts.c
> @@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
> __set_bit(BTN_TOUCH, input_dev->keybit);
> input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
> input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
> - input_set_drvdata(input_dev, data);
>
> max11801_ts_phy_init(data);
>
>

\
 
 \ /
  Last update: 2017-01-22 12:26    [W:0.064 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site