lkml.org 
[lkml]   [2017]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] phy: qcom-ufs: Don't kfree devres resource
    On 2017-01-19 02:47, Bjorn Andersson wrote:
    > Upon failing to acquire regulator supplies the qcom-ufs driver calls
    > kfree() on the devm allocated memory used to store the name of the
    > regulator, leading to devres corruption.
    >
    > Rather than switching to using the appropriate free function the patch
    > acknowledge the fact that "name" is always a constant string and we
    > don't actually need to create a local copy of it, but rather just
    > reference the constant string.
    >
    > Cc: Subhash Jadavani <subhashj@codeaurora.org>
    > Cc: Vivek Gautam <vivek.gautam@codeaurora.org>
    > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    > ---
    > drivers/phy/phy-qcom-ufs.c | 9 +--------
    > 1 file changed, 1 insertion(+), 8 deletions(-)
    >
    > diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
    > index c69568b8543d..4d7f3c018223 100644
    > --- a/drivers/phy/phy-qcom-ufs.c
    > +++ b/drivers/phy/phy-qcom-ufs.c
    > @@ -217,12 +217,7 @@ static int __ufs_qcom_phy_init_vreg(struct device
    > *dev,
    >
    > char prop_name[MAX_PROP_NAME];
    >
    > - vreg->name = devm_kstrdup(dev, name, GFP_KERNEL);
    > - if (!vreg->name) {
    > - err = -ENOMEM;
    > - goto out;
    > - }
    > -
    > + vreg->name = name;
    > vreg->reg = devm_regulator_get(dev, name);
    > if (IS_ERR(vreg->reg)) {
    > err = PTR_ERR(vreg->reg);
    > @@ -265,8 +260,6 @@ static int __ufs_qcom_phy_init_vreg(struct device
    > *dev,
    > }
    >
    > out:
    > - if (err)
    > - kfree(vreg->name);
    > return err;
    > }

    Looks good to me.
    Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

    --
    The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project

    \
     
     \ /
      Last update: 2017-01-20 21:10    [W:2.470 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site