Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH] power: supply: bq2415x: check for NULL acpi_id to avoid null pointer dereference | Date | Fri, 20 Jan 2017 13:25:06 +0000 |
| |
From: Colin Ian King <colin.king@canonical.com>
acpi_match_device can potentially return NULL, so it is prudent to check if acpi_id is null before it is dereferenced. Add a check and an error message to indicate the failure.
Signed-off-by: Colin Ian King <colin.king@canonical.com> --- drivers/power/supply/bq2415x_charger.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c index 73e2f0b..c4770a9 100644 --- a/drivers/power/supply/bq2415x_charger.c +++ b/drivers/power/supply/bq2415x_charger.c @@ -1569,6 +1569,11 @@ static int bq2415x_probe(struct i2c_client *client, acpi_id = acpi_match_device(client->dev.driver->acpi_match_table, &client->dev); + if (!acpi_id) { + dev_err(&client->dev, "failed to match device name\n"); + ret = -ENODEV; + goto error_1; + } name = kasprintf(GFP_KERNEL, "%s-%d", acpi_id->id, num); } if (!name) { -- 2.10.2
| |