lkml.org 
[lkml]   [2017]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 13/33] Input: bfin_rotary - Use 'dev' instead of dereferencing it and other changes
From
Date
On Wed, 2017-01-18 at 12:35 -0800, Guenter Roeck wrote:
> On Wed, Jan 18, 2017 at 11:39:52AM -0800, Dmitry Torokhov wrote:
> > On Wed, Jan 18, 2017 at 09:46:34AM -0800, Guenter Roeck wrote:
[]
> > > diff --git a/drivers/input/misc/bfin_rotary.c b/drivers/input/misc/bfin_rotary.c
[]
> > > @@ -141,25 +141,23 @@ static int bfin_rotary_probe(struct platform_device *pdev)
> > >
> > > /* Basic validation */
> > > if ((pdata->rotary_up_key && !pdata->rotary_down_key) ||
> > > - (!pdata->rotary_up_key && pdata->rotary_down_key)) {
> > > + (!pdata->rotary_up_key && pdata->rotary_down_key))

maybe just use ^

if (!pdata->rotary_up_key ^ !pdata->rotary_down_key)

\
 
 \ /
  Last update: 2017-01-19 06:00    [W:0.102 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site