lkml.org 
[lkml]   [2017]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4.9 033/120] perf/x86/intel/uncore: Fix hardcoded socket 0 assumption in the Haswell init code
    On Wed, Jan 18, 2017 at 09:38:07AM -0500, Prarit Bhargava wrote:
    >
    >
    > On 01/18/2017 05:45 AM, Greg Kroah-Hartman wrote:
    > > 4.9-stable review patch. If anyone has any objections, please let me know.
    > >
    >
    > Nack.
    >
    > The value of boot_cpu_data.logical_proc_id may be uninitialized and set to
    > default -1 on systems that pick a random core as boot cpu. This was
    > inadvertently fixed by 9d85eb9119f4 ("x86/smpboot: Make logical package
    > management more robust") which is in 4.10-rc1.
    >
    > Before 9d85eb9119f4:
    >
    > [ 3.971539] hswep_uncore_cpu_init: cpu 5 pkg 0 boot_cpu_data.logical_proc_id
    > 65535
    > [ 3.976504] hswep_uncore_cpu_init: cpu 5 pkg 0 cpu_data(0).logical_proc_id 0
    >
    > After 9d85eb9119f4:
    >
    > [ 3.919112] hswep_uncore_cpu_init: cpu 5 pkg 0 boot_cpu_data.logical_proc_id 0
    > [ 3.923391] hswep_uncore_cpu_init: cpu 5 pkg 0 cpu_data(0).logical_proc_id 0
    >
    > This patch should not be applied to any stable branch.

    So the fixes: line lies? This isn't needed at all for 4.9?

    confused,

    greg k-h

    \
     
     \ /
      Last update: 2017-01-18 17:44    [W:3.705 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site