Messages in this thread | | | Date | Wed, 18 Jan 2017 12:56:48 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 02/11] perf, tools: Parse eventcode as number in jevents |
| |
On Mon, Jan 09, 2017 at 05:10:05PM -0800, Andi Kleen wrote: > > > for (f = fields; f->field; f++) > > > if (json_streq(map, field, f->field) && nz) { > > > + /* Handle all variations of 0 encounted in JSON */ > > > + if (json_streq(map, val, "0x00") || > > > + json_streq(map, val, "0x0")) > > > + return 1; > > > > how is this related to the patch? also shouldn't it return 0 ? > > I removed it now. It avoids some extra umask=0x0 entries, but these > don't hurt.
ack on the version in the branch, but you haven't posted that one
jirka
| |