Messages in this thread Patch in this message | | | Date | Wed, 18 Jan 2017 02:57:58 -0800 | From | tip-bot for Tobias Klauser <> | Subject | [tip:smp/urgent] cpu/hotplug: Remove unused but set variable in _cpu_down() |
| |
Commit-ID: 0fec9557fd0c5349e3bd1a2141612a60bc20bb71 Gitweb: http://git.kernel.org/tip/0fec9557fd0c5349e3bd1a2141612a60bc20bb71 Author: Tobias Klauser <tklauser@distanz.ch> AuthorDate: Tue, 17 Jan 2017 15:35:01 +0100 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Wed, 18 Jan 2017 11:55:09 +0100
cpu/hotplug: Remove unused but set variable in _cpu_down()
After the recent removal of the hotplug notifiers the variable 'hasdied' in _cpu_down() is set but no longer read, leading to the following GCC warning when building with 'make W=1':
kernel/cpu.c:767:7: warning: variable ‘hasdied’ set but not used [-Wunused-but-set-variable]
Fix it by removing the variable.
Fixes: 530e9b76ae8f ("cpu/hotplug: Remove obsolete cpu hotplug register/unregister functions") Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Cc: rt@linutronix.de Link: http://lkml.kernel.org/r/20170117143501.20893-1-tklauser@distanz.ch Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
--- kernel/cpu.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c index c475063..0a5f630 100644 --- a/kernel/cpu.c +++ b/kernel/cpu.c @@ -764,7 +764,6 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, { struct cpuhp_cpu_state *st = per_cpu_ptr(&cpuhp_state, cpu); int prev_state, ret = 0; - bool hasdied = false; if (num_online_cpus() == 1) return -EBUSY; @@ -809,7 +808,6 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen, cpuhp_kick_ap_work(cpu); } - hasdied = prev_state != st->state && st->state == CPUHP_OFFLINE; out: cpu_hotplug_done(); return ret;
| |