lkml.org 
[lkml]   [2017]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v6 kernel 3/5] virtio-balloon: speed up inflate/deflate process
Date
> > -	virtqueue_add_outbuf(vq, &sg, 1, vb, GFP_KERNEL);
> > - virtqueue_kick(vq);
> > +static void do_set_resp_bitmap(struct virtio_balloon *vb,
> > + unsigned long base_pfn, int pages)
> >
> > - /* When host has read buffer, this completes via balloon_ack */
> > - wait_event(vb->acked, virtqueue_get_buf(vq, &len));
> > +{
> > + __le64 *range = vb->resp_data + vb->resp_pos;
> >
> > + if (pages > (1 << VIRTIO_BALLOON_NR_PFN_BITS)) {
> > + /* when the length field can't contain pages, set it to 0 to
>
> /*
> * Multi-line
> * comments
> * should look like this.
> */
>
> Also, pls start sentences with an upper-case letter.
>

Sorry for that.

> > + * indicate the actual length is in the next __le64;
> > + */
>
> This is part of the interface so should be documented as such.
>
> > + *range = cpu_to_le64((base_pfn <<
> > + VIRTIO_BALLOON_NR_PFN_BITS) | 0);
> > + *(range + 1) = cpu_to_le64(pages);
> > + vb->resp_pos += 2;
>
> Pls use structs for this kind of stuff.

I am not sure if you mean to use

struct range {
__le64 pfn: 52;
__le64 nr_page: 12
}
Instead of the shift operation?

I didn't use this way because I don't want to include 'virtio-balloon.h' in page_alloc.c,
or copy the define of this struct in page_alloc.c

Thanks!
Liang

\
 
 \ /
  Last update: 2017-01-18 06:00    [W:0.077 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site