Messages in this thread | | | From | Andy Lutomirski <> | Date | Tue, 17 Jan 2017 12:27:00 -0800 | Subject | Re: [PATCHv2 2/5] x86/mm: introduce mmap_{,legacy}_base |
| |
On Mon, Jan 16, 2017 at 4:33 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote: > In the following patch they will be used to compute: > - mmap_base in compat sys_mmap() in native 64-bit binary > and vice-versa > - mmap_base for native sys_mmap() in compat x32/ia32-bit binary.
I may be wrong here, but I suspect that you're repeating something that I consider to be a mistake that's all over the x86 code. Specifically, you're distinguishing "native" from "compat" instead of "32-bit" from "64-bit". If you did the latter, then you wouldn't need the "native" case to work differently on 32-bit kernels vs 64-bit kernels, I think. Would making this change make your code simpler?
The x86 signal code is the worst offender IMO.
--Andy
| |